Implement onFileDeleted->onFileDelete method name change#1517
Merged
niveathika merged 9 commits intoballerina-platform:masterfrom Dec 16, 2025
Merged
Implement onFileDeleted->onFileDelete method name change#1517niveathika merged 9 commits intoballerina-platform:masterfrom
niveathika merged 9 commits intoballerina-platform:masterfrom
Conversation
niveathika
requested review from
DimuthuMadushan,
MohamedSabthar,
ThisaruGuruge and
shafreenAnfar
as code owners
niveathika
requested review from
Copilot
and removed request for
DimuthuMadushan,
MohamedSabthar,
ThisaruGuruge and
shafreenAnfar
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a method name change from onFileDeleted to onFileDelete for handling file deletion events in the FTP service. The change includes deprecating the old method while maintaining backward compatibility, and modifies the callback behavior to invoke the handler once per deleted file (with a string parameter) instead of once for all files (with a string[] parameter).
Key Changes:
- Introduced
onFileDelete(string deletedFile)as the new deletion handler, called once per deleted file - Deprecated
onFileDeleted(string[] deletedFiles)with warning diagnostics while maintaining backward compatibility - Updated compiler plugin validation to support both methods with appropriate deprecation warnings and mutual exclusivity checks
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| native/src/main/java/io/ballerina/stdlib/ftp/util/FtpConstants.java | Added constant for new onFileDelete method name |
| native/src/main/java/io/ballerina/stdlib/ftp/util/FtpUtil.java | Updated method detection to support both old and new method names |
| native/src/main/java/io/ballerina/stdlib/ftp/server/FtpListener.java | Implemented new processDeletionCallback that dispatches to appropriate handler based on parameter type, added processFileDeleteCallback for per-file invocation |
| compiler-plugin/src/main/java/io/ballerina/stdlib/ftp/plugin/PluginConstants.java | Added new error codes and messages for onFileDelete validation and deprecation warnings |
| compiler-plugin/src/main/java/io/ballerina/stdlib/ftp/plugin/FtpServiceValidator.java | Added validation logic to check for both methods and ensure they're not used simultaneously |
| compiler-plugin/src/main/java/io/ballerina/stdlib/ftp/plugin/FtpFileDeletedValidator.java | Refactored validator to support both method types with appropriate parameter validation |
| compiler-plugin-tests/src/test/java/io/ballerina/stdlib/ftp/plugin/FtpServiceValidationTest.java | Added comprehensive tests for onFileDelete validation scenarios |
| compiler-plugin-tests/src/test/resources/ballerina_sources/* | Added test cases for valid and invalid onFileDelete usage patterns |
| docs/spec/spec.md | Updated specification to document the new onFileDelete method |
| ballerina/tests/listener_on_file_deleted_test.bal | Updated tests to use new onFileDelete method with per-file invocation pattern |
| ballerina/client_endpoint.bal | Repositioned deprecation notices (though placement is inconsistent with best practices) |
| ballerina/caller.bal | Repositioned deprecation notices (though placement is inconsistent with best practices) |
| ballerina/Ballerina.toml | Added unrelated ballerina/cluster dependency that should be justified or removed |
| changelog.md | Documented the deprecation (with a spelling error) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1517 +/- ##
============================================
+ Coverage 80.41% 80.75% +0.33%
- Complexity 532 747 +215
============================================
Files 43 58 +15
Lines 2732 3357 +625
Branches 432 567 +135
============================================
+ Hits 2197 2711 +514
- Misses 357 404 +47
- Partials 178 242 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
niveathika
added
the
Skip GraalVM Check
Nuvindu
reviewed
Dec 15, 2025
...-plugin-tests/src/test/resources/ballerina_sources/invalid_content_service_22/Ballerina.toml
Outdated
Show resolved
Hide resolved
...ler-plugin-tests/src/test/resources/ballerina_sources/invalid_content_service_22/service.bal
Show resolved
Hide resolved
|
Nuvindu
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Examples
Checklist